Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import protoutils from core fabric #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

import protoutils from core fabric #23

wants to merge 2 commits into from

Conversation

davidkhala
Copy link
Member

@davidkhala davidkhala commented Jan 17, 2024 •
edited
Loading

fabric core context dependency was discovered and marked here.
davidkhala/protoutil#1

After this is merged, migrate dependency on ./protoutil/common to github.com/hyperledger/fabric-lib-go/common

@davidkhala davidkhala requested a review from a team as a code owner January 17, 2024 19:55
@davidkhala
init commit
a2ea789 
Signed-off-by: David Liu <david-khala@hotmail.com>
@davidkhala
Copy link
Member Author

Apologize, I find this implementation has already migated to use github.com/hyperledger/fabric-protos-go-apiv2. Should I revert or just go ahead?

@davidkhala
init commit part2
baeee21 
Signed-off-by: David Liu <david-khala@hotmail.com>
@davidkhala
Copy link
Member Author

@denyeart Ready to review.

@davidkhala davidkhala changed the title init commit import protoutils from core fabric Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davidkhala